Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 870353004: cps-ir: Implement string concatenation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js/builder.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index d97abb45d0812d06cdc18b90137c920ec581bbec..0755833ef5afd14e3d92b05b3256744f195182b4 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -134,8 +134,28 @@ class CodeGenerator extends tree_ir.Visitor<dynamic, js.Expression> {
@override
js.Expression visitConcatenateStrings(tree_ir.ConcatenateStrings node) {
- return giveup(node);
- // TODO: implement visitConcatenateStrings
+ js.Expression addStrings(js.Expression left, js.Expression right) {
+ return new js.Binary('+', left, right);
+ }
+
+ js.Expression toString(tree_ir.Expression input) {
+ bool useDirectly = input is tree_ir.Constant &&
+ (input.expression.value.isString ||
+ input.expression.value.isInt ||
+ input.expression.value.isBool);
+ js.Expression value = visit(input);
+ if (useDirectly) {
+ return value;
+ } else {
+ Element convertToString = glue.getStringConversion();
+ registry.registerStaticUse(convertToString);
+ js.Expression access = glue.staticFunctionAccess(convertToString);
+ return (new js.Call(access, <js.Expression>[value]));
+ }
+ }
+
+ Iterable<js.Expression> parts = node.arguments.map(toString);
+ return parts.skip(1).fold(parts.first, addStrings);
asgerf 2015/02/06 10:37:25 Could be: parts.reduce(addStrings)
}
@override
« no previous file with comments | « pkg/compiler/lib/src/js/builder.dart ('k') | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698