Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 870353003: Split src/opts source lists out of opts.gyp. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Split src/opts source lists out of opts.gyp. This should make it easier to keep our opts.gyp in sync with Chrome's GYP and GN. BUG=skia: Landing this without review as a mega-tryjob. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/c98fe3aa4f8c97c462c0eb6d9106fc37e48d7f82 Committed: https://skia.googlesource.com/skia/+/f7069d58fc7b323437e8a65a82d5d839e92c9ffe

Patch Set 1 #

Patch Set 2 : fix n9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -203 lines) Patch
M gyp/opts.gyp View 1 6 chunks +51 lines, -202 lines 0 comments Download
A gyp/opts.gypi View 1 chunk +83 lines, -0 lines 0 comments Download
M gyp/skia_lib.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870353003/1
5 years, 11 months ago (2015-01-27 01:59:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c98fe3aa4f8c97c462c0eb6d9106fc37e48d7f82
5 years, 11 months ago (2015-01-27 02:05:43 UTC) #3
mtklein
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/880783002/ by mtklein@google.com. ...
5 years, 11 months ago (2015-01-27 02:14:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870353003/20001
5 years, 11 months ago (2015-01-27 02:29:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870353003/20001
5 years, 11 months ago (2015-01-27 02:55:53 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 02:56:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f7069d58fc7b323437e8a65a82d5d839e92c9ffe

Powered by Google App Engine
This is Rietveld 408576698