Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/pdf/SkPDFShader.cpp

Issue 870333002: Simplify reference management in SkPDF (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: make Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/pdf/SkPDFShader.h ('k') | src/pdf/SkPDFTypes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pdf/SkPDFShader.cpp
diff --git a/src/pdf/SkPDFShader.cpp b/src/pdf/SkPDFShader.cpp
index 20df873cbd14b7ba60a7a252cab2d499cf3518e9..b20be99b0a1bf21fe78e1f4466fe9829a0f37837 100644
--- a/src/pdf/SkPDFShader.cpp
+++ b/src/pdf/SkPDFShader.cpp
@@ -510,11 +510,6 @@ private:
SkPDFFunctionShader::SkPDFFunctionShader(SkPDFShader::State* state)
: SkPDFDict("Pattern"), fShaderState(state) {}
-void SkPDFFunctionShader::getResources(const SkTSet<SkPDFObject*>& known,
- SkTSet<SkPDFObject*>* newr) {
- GetResourcesHelper(&fResources, known, newr);
-}
-
SkPDFFunctionShader::~SkPDFFunctionShader() {
SkAutoMutexAcquire lock(SkPDFCanon::GetShaderMutex());
SkPDFCanon::GetCanon().removeFunctionShader(this);
@@ -540,11 +535,6 @@ SkPDFAlphaFunctionShader::~SkPDFAlphaFunctionShader() {
SkPDFCanon::GetCanon().removeAlphaShader(this);
}
-void SkPDFAlphaFunctionShader::getResources(const SkTSet<SkPDFObject*>& known,
- SkTSet<SkPDFObject*>* newr) {
- fResourceDict->getReferencedResources(known, newr, true);
-}
-
////////////////////////////////////////////////////////////////////////////////
SkPDFImageShader::SkPDFImageShader(SkPDFShader::State* state)
@@ -561,11 +551,6 @@ SkPDFImageShader::~SkPDFImageShader() {
fResources.unrefAll();
}
-void SkPDFImageShader::getResources(const SkTSet<SkPDFObject*>& known,
- SkTSet<SkPDFObject*>* newr) {
- GetResourcesHelper(&fResources.toArray(), known, newr);
-}
-
////////////////////////////////////////////////////////////////////////////////
static SkPDFObject* get_pdf_shader_by_state(
@@ -1129,10 +1114,6 @@ SkPDFImageShader* SkPDFImageShader::Create(
SkNEW_ARGS(SkPDFImageShader, (autoState->detach()));
imageShader->setData(content.get());
- SkPDFResourceDict* resourceDict = pattern.getResourceDict();
- resourceDict->getReferencedResources(imageShader->fResources,
- &imageShader->fResources, false);
-
populate_tiling_pattern_dict(imageShader, patternBBox,
pattern.getResourceDict(), finalMatrix);
« no previous file with comments | « src/pdf/SkPDFShader.h ('k') | src/pdf/SkPDFTypes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698