Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 870273002: Revert of Copy debug PNaCl plugin in Dev builds of the chromoting webapp. (Closed)

Created:
5 years, 11 months ago by Sergiy Byelozyorov
Modified:
5 years, 11 months ago
Reviewers:
Sergey Ulanov, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@all
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Copy debug PNaCl plugin in Dev builds of the chromoting webapp. (patchset #1 id:1 of https://codereview.chromium.org/872633006/) Reason for revert: Broke compile, e.g. http://build.chromium.org/p/chromium/buildstatus?builder=Win&number=28337 Original issue's description: > Copy debug PNaCl plugin in Dev builds of the chromoting webapp. > > With this change the Debug version of the PNaCl plugin will be copied to > the webapp directory allowing to debug PNaCl plugin (using nacl-gdb). > > Also updated build-webapp.py to process all *.jinja2 input files as jinja2 > templates. > > BUG=451643 > > Committed: https://crrev.com/65ffdafc8538b14ad0cbdf6a57d9d21e1e882a9d > Cr-Commit-Position: refs/heads/master@{#313024} TBR=jamiewalch@chromium.org,sergeyu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=451643 Committed: https://crrev.com/c82e9b0a281f21501765b27a23cda508e11a5e1f Cr-Commit-Position: refs/heads/master@{#313025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -36 lines) Patch
M remoting/remoting_client.gypi View 1 chunk +1 line, -10 lines 0 comments Download
M remoting/webapp/build-webapp.py View 1 chunk +19 lines, -10 lines 0 comments Download
A remoting/webapp/crd/remoting_client_pnacl.nmf View 1 chunk +10 lines, -0 lines 0 comments Download
D remoting/webapp/crd/remoting_client_pnacl.nmf.jinja2 View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sergiy Byelozyorov
Created Revert of Copy debug PNaCl plugin in Dev builds of the chromoting webapp.
5 years, 11 months ago (2015-01-24 19:29:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870273002/1
5 years, 11 months ago (2015-01-24 19:30:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 19:31:38 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 19:32:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c82e9b0a281f21501765b27a23cda508e11a5e1f
Cr-Commit-Position: refs/heads/master@{#313025}

Powered by Google App Engine
This is Rietveld 408576698