Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 870203003: [Mac, Linux] Add People in the menu bar should automatically create a default profile (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac, Linux] Add People in the menu bar should automatically create a default profile This will make it have the same behaviour as the User Manager, vs. navigating to chrome://settings/createProfile. BUG=452125 TEST=Choose Add Person from the OS menu bar. This should create a profile and switch to it immediately. Committed: https://crrev.com/f13cd124b647cb47ac25e2eaefe6a49f7e1a651f Cr-Commit-Position: refs/heads/master@{#313586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
noms (inactive)
Hi, This CL changes the behaviour of the "Add Person" OS menu option to match ...
5 years, 10 months ago (2015-01-28 16:08:23 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-01-28 16:10:08 UTC) #3
sky
views LGTM
5 years, 10 months ago (2015-01-28 21:10:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870203003/1
5 years, 10 months ago (2015-01-28 21:12:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 21:26:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 21:28:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f13cd124b647cb47ac25e2eaefe6a49f7e1a651f
Cr-Commit-Position: refs/heads/master@{#313586}

Powered by Google App Engine
This is Rietveld 408576698