Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870203002: Add status to server credit cards. (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add status to server credit cards. Update some dialog strings for unmasking/updating expired cards. TODO: Actual month/year inputs. BUG=451654 Committed: https://crrev.com/ef2ee8838696fa4f4dda755c7bde53ccc0de15c5 Cr-Commit-Position: refs/heads/master@{#313120}

Patch Set 1 #

Patch Set 2 : another ctor #

Patch Set 3 : test updates #

Total comments: 2

Patch Set 4 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc View 1 2 3 2 chunks +19 lines, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.h View 3 chunks +14 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 6 chunks +25 lines, -4 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table.cc View 4 chunks +37 lines, -2 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
5 years, 11 months ago (2015-01-24 02:31:15 UTC) #2
brettw
lgtm https://codereview.chromium.org/870203002/diff/40001/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc File chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc (right): https://codereview.chromium.org/870203002/diff/40001/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc#newcode61 chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc:61: if (card_.GetServerStatus() == CreditCard::EXPIRED) { Can we add ...
5 years, 10 months ago (2015-01-26 06:02:27 UTC) #3
Evan Stade
https://codereview.chromium.org/870203002/diff/40001/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc File chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc (right): https://codereview.chromium.org/870203002/diff/40001/chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc#newcode61 chrome/browser/ui/autofill/card_unmask_prompt_controller_impl.cc:61: if (card_.GetServerStatus() == CreditCard::EXPIRED) { On 2015/01/26 06:02:26, brettw ...
5 years, 10 months ago (2015-01-26 19:41:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870203002/60001
5 years, 10 months ago (2015-01-26 19:42:07 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-01-26 20:33:36 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-26 20:34:35 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ef2ee8838696fa4f4dda755c7bde53ccc0de15c5
Cr-Commit-Position: refs/heads/master@{#313120}

Powered by Google App Engine
This is Rietveld 408576698