Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 870183004: Revert of cc: Control defer_commits logic by Scheduler (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, jamesr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Control defer_commits logic by Scheduler (patchset #12 id:250001 of https://codereview.chromium.org/337693005/) Reason for revert: seems to flakily not stop commits https://code.google.com/p/chromium/issues/detail?id=453787 Original issue's description: > cc: Control defer_commits logic by Scheduler > > So far, EarlyOut_DeferCommits is controlled by Proxy. > Because Scheduler doesn't know about this deferring, it triggers next > BeginMainFrame when main thread want to defer a commit. > This CL moves the EarlyOut_DeferCommits logic from Proxy to > Scheduler so Scheduler can stop next BeginMainFrame until defer commit is off. > > R=brianderson@chromium.org, danakj@chromium.org, skyostil@chromium.org > BUG=382572 > TEST=cc_unittests > > Committed: https://crrev.com/1625b74468e4dd55f54ba209f8e91d05493875b9 > Cr-Commit-Position: refs/heads/master@{#313816} TBR=brianderson@chromium.org,skyostil@chromium.org,enne@chromium.org,mithro@mithis.com,simonhong@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=382572 Committed: https://crrev.com/06b3f03355d6fb783273eb4fd26e91830be2ce44 Cr-Commit-Position: refs/heads/master@{#313939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -304 lines) Patch
M cc/scheduler/commit_earlyout_reason.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 5 chunks +1 line, -12 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M cc/test/layer_tree_test.h View 3 chunks +1 line, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 6 chunks +11 lines, -94 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 5 chunks +40 lines, -60 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
Created Revert of cc: Control defer_commits logic by Scheduler
5 years, 10 months ago (2015-01-30 17:47:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870183004/1
5 years, 10 months ago (2015-01-30 17:49:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 17:50:34 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:52:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06b3f03355d6fb783273eb4fd26e91830be2ce44
Cr-Commit-Position: refs/heads/master@{#313939}

Powered by Google App Engine
This is Rietveld 408576698