Move networking_private to src/extensions

chrome/browser/extensions/chrome_extensions_browser_client.cc

Index: chrome/browser/extensions/chrome_extensions_browser_client.cc
diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.cc b/chrome/browser/extensions/chrome_extensions_browser_client.cc
index 215fcde7795c69cae6878c1179e28935ee192433..377978330febe98b5f2779038ef6a5b5d254ebd3 100644
--- a/chrome/browser/extensions/chrome_extensions_browser_client.cc
+++ b/chrome/browser/extensions/chrome_extensions_browser_client.cc
@@ -39,6 +39,7 @@
 #include "extensions/browser/url_request_util.h"
 
 #if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/extensions/updater/extension_cache_impl.h"
 #include "chromeos/chromeos_switches.h"
 #else
@@ -99,6 +100,16 @@ content::BrowserContext* ChromeExtensionsBrowserClient::GetOriginalContext(
   return static_cast<Profile*>(context)->GetOriginalProfile();
 }
 
+std::string ChromeExtensionsBrowserClient::GetUserIdHashFromContext(
+    content::BrowserContext* context) {
+#if defined(OS_CHROMEOS)
+  return chromeos::ProfileHelper::GetUserIdHashFromProfile(
+      static_cast<Profile*>(context));
+#else
+  return context->GetPath().BaseName().value();

[James Cook, 2015/01/24 03:59:24]

I don't like this. Isn't the Chrome OS version depending on the path part
looking something like a hash?  (Doesn't the cryptohome path have something
hash-y in it? u-12345abcdef or similar?)  I think this code means on Windows/Mac
that the UserIdHash will be "Default" or "James", which could leak information
if the calling code expects something obfuscated. I would either NOTREACHED() or
return "" or an error string.

[stevenjb, 2015/01/26 20:36:19]

I'm going to go ahead and make this method Chrome OS only so that nobody
accidentally uses it on another platform.

[James Cook, 2015/01/26 21:20:55]

Sounds good.

+#endif
+}
+
 bool ChromeExtensionsBrowserClient::IsGuestSession(
     content::BrowserContext* context) const {
   return static_cast<Profile*>(context)->IsGuestSession();