Move networking_private to src/extensions

extensions/shell/browser/shell_extensions_browser_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/shell/browser/shell_extensions_browser_client.h"
 
+#include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "extensions/browser/api/extensions_api_client.h"
 #include "extensions/browser/api/generated_api_registration.h"
 #include "extensions/browser/app_sorting.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_function_registry.h"
 #include "extensions/browser/null_app_sorting.h"
 #include "extensions/browser/updater/null_extension_cache.h"
 #include "extensions/browser/url_request_util.h"
 #include "extensions/shell/browser/api/generated_api_registration.h"
@@ skipping 47 matching lines @@
     BrowserContext* context) {
   // app_shell only supports a single context.
   return NULL;
 }
 
 BrowserContext* ShellExtensionsBrowserClient::GetOriginalContext(
     BrowserContext* context) {
   return context;
 }
 
+std::string ShellExtensionsBrowserClient::GetUserIdHashFromContext(
+    content::BrowserContext* context) {
+  return context->GetPath().BaseName().value();

[James Cook, 2015/01/24 03:59:24]

app_shell on Brillo doesn't have a real logged-in user, so not really a
cryptohome, so this may not be very hash-y. It might just end up as "user". Is
that OK, or would you prefer returning a known fixed string?

[stevenjb, 2015/01/26 20:36:19]

Returning an empty string. If that ends up causing problems down the road we can
fix it for real at that point.

[James Cook, 2015/01/26 21:20:55]

I'm nervous that this might cause a hard-to-interpret app_shell bug sometime
down the road. I'm having a hard time figuring out what this ID is used for.

Do you know if this function is called just by starting up chrome/app_shell? If
it won't spam, maybe it should also have a NOTIMPLEMENTED()?

[stevenjb, 2015/01/27 01:39:37]

This is only called from the networkingPrivate API to ensure that
networkingPrivate is called for the correct (i.e. primary) user.

I'll change this to call chromeos::LoginState::Get()->primary_user_hash() which
is what networkingPrivate expects, with a TODO to change this if we ever support
multi profile in app_shell.

+}
+
 bool ShellExtensionsBrowserClient::IsGuestSession(
     BrowserContext* context) const {
   return false;
 }
 
 bool ShellExtensionsBrowserClient::IsExtensionIncognitoEnabled(
     const std::string& extension_id,
     content::BrowserContext* context) const {
   return false;
 }
@@ skipping 130 matching lines @@
     const std::string& min_version) {
   return true;
 }
 
 void ShellExtensionsBrowserClient::SetAPIClientForTest(
     ExtensionsAPIClient* api_client) {
   api_client_.reset(api_client);
 }
 
 }  // namespace extensions