Move networking_private to src/extensions

extensions/common/permissions/extensions_api_permissions.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/permissions/extensions_api_permissions.h"
 
 #include <vector>
 
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/permission_message.h"
@@ skipping 51 matching lines @@
        PermissionMessage::kDeclarativeWebRequest},
       {APIPermission::kDns, "dns"},
       {APIPermission::kExternallyConnectableAllUrls,
        "externally_connectable.all_urls"},
       {APIPermission::kFullscreen, "app.window.fullscreen"},
       {APIPermission::kHid, "hid", APIPermissionInfo::kFlagNone},
       {APIPermission::kImeWindowEnabled, "app.window.ime"},
       {APIPermission::kOverrideEscFullscreen,
        "app.window.fullscreen.overrideEsc"},
       {APIPermission::kIdle, "idle"},
+      {APIPermission::kNetworkingPrivate,
+       "networkingPrivate",
+       APIPermissionInfo::kFlagCannotBeOptional,

[asargent_no_longer_on_chrome, 2015/01/27 18:31:00]

Is there any reason why this permission cannot be optional? In general we'd
prefer that all permissions be available optionally whenever possible. (I
realize this is the way it was before; just wondering if there was a good reason
or it was just cargo culting other code)

[stevenjb, 2015/01/27 19:24:51]

I think this is OK for now. This is a private API and it is highly unlikely that
something using this API wouldn't be badly broken without it.

That said, we can certainly discuss this separately and consider changing to
granting permissions on demand in the future. For the public networking APIs we
are working on that definitely seems like a better approach.

+       IDS_EXTENSION_PROMPT_WARNING_NETWORKING_PRIVATE,
+       PermissionMessage::kNetworkingPrivate},
       {APIPermission::kPower, "power"},
       {APIPermission::kPrinterProvider, "printerProvider"},
       {APIPermission::kSerial,
        "serial",
        APIPermissionInfo::kFlagNone,
        IDS_EXTENSION_PROMPT_WARNING_SERIAL,
        PermissionMessage::kSerial},
       // Because warning messages for the "socket" permission vary based
       // on the permissions parameters, no message ID or message text is
       // specified here.  The message ID and text used will be
@@ skipping 68 matching lines @@
                                                    kOldFullscreenPermission));
   aliases.push_back(
       PermissionsProvider::AliasInfo("app.window.fullscreen.overrideEsc",
                                      kOldOverrideEscFullscreenPermission));
   aliases.push_back(PermissionsProvider::AliasInfo(
       "unlimitedStorage", kOldUnlimitedStoragePermission));
   return aliases;
 }
 
 }  // namespace extensions