mojo/public/tools/pylib/gs.py - Issue 870143008: Move //tools/gs.py into //mojo/public/tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/pylib/gs.py

Issue 870143008: Move //tools/gs.py into //mojo/public/tools (Closed) Base URL: https://github.com/domokit/mojo.git@expose_downloading_network_service

Patch Set: Response to review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/pylib/gs.py

diff --git a/tools/gs.py b/mojo/public/tools/pylib/gs.py

old mode 100755

new mode 100644

similarity index 88%

rename from tools/gs.py

rename to mojo/public/tools/pylib/gs.py

index b277d0502d685699593dab0894fd50ebf9791ddd..5331d16bab118aa72e102325bb8ec76ca90dbbf3

--- a/tools/gs.py

+++ b/mojo/public/tools/pylib/gs.py

@@ -1,4 +1,3 @@

-#!/usr/bin/env python

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

@@ -6,9 +5,11 @@

import os

import subprocess

import sys

-import find_depot_tools

-def download_from_public_bucket(gs_path, output_path):

+def download_from_public_bucket(gs_path, output_path, find_depot_tools_path):

viettrungluu 2015/02/12 17:20:25 It occurs to me that this is a very strange API. P

blundell 2015/02/12 19:31:28 Done.

+ sys.path.insert(0, find_depot_tools_path)

+ # pylint: disable=F0401

+ import find_depot_tools

depot_tools_path = find_depot_tools.add_depot_tools_to_path()

gsutil_exe = os.path.join(depot_tools_path, "third_party", "gsutil", "gsutil")

« no previous file with comments | « mojo/public/tools/download_shell_binary.py ('k') | mojo/tools/roll/roll_network_service.py » ('j') | no next file with comments »