chrome/browser/history/history_querying_unittest.cc - Issue 870143004: HistoryService::Init() receives the list of languages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_querying_unittest.cc

Issue 870143004: HistoryService::Init() receives the list of languages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-history-service

Patch Set: Address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/history_querying_unittest.cc

diff --git a/chrome/browser/history/history_querying_unittest.cc b/chrome/browser/history/history_querying_unittest.cc

index 3cdf1e9315242b2ab09f4fa87b42f4f1d4c768fd..b9d55b98799f3b48dab1609c5045b82c381063cb 100644

--- a/chrome/browser/history/history_querying_unittest.cc

+++ b/chrome/browser/history/history_querying_unittest.cc

@@ -167,7 +167,8 @@ class HistoryQueryTest : public testing::Test {

ASSERT_TRUE(base::CreateDirectory(history_dir_));

history_.reset(new HistoryService);

- if (!history_->Init(TestHistoryDatabaseParamsForPath(history_dir_))) {

+ if (!history_->Init(std::string(),

+ TestHistoryDatabaseParamsForPath(history_dir_))) {

history_.reset(); // Tests should notice this NULL ptr & fail.

return;

}

« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | chrome/browser/history/history_service.h » ('j') | no next file with comments »