Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 870133002: Move to SkStreamAsset for SkTypeface streams. (Closed)

Created:
5 years, 11 months ago by bungeman-chromium
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move to SkStreamAsset for SkTypeface streams. SkTypeface is moving to use SkStreamAsset instead of SkStream. The implementations are already assuming this, and all users are in practice already creating the correct types. This change simply clarifies existing practice and documents actual restrictions. The Skia side change will be https://codereview.chromium.org/869763002/ Committed: https://crrev.com/9be085c313537c895fcaf1b8ec2ab33593743fee Cr-Commit-Position: refs/heads/master@{#313196}

Patch Set 1 #

Patch Set 2 : Fix includes. #

Patch Set 3 : Covariance requires proof. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M content/common/font_config_ipc_linux.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M content/common/font_config_ipc_linux.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-chromium
This doesn't change any behavior or bits, it just clarifies the actual type being used.
5 years, 11 months ago (2015-01-26 17:15:31 UTC) #2
jam
lgtm
5 years, 11 months ago (2015-01-26 22:17:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870133002/40001
5 years, 11 months ago (2015-01-27 00:53:15 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-27 01:41:29 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:42:48 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9be085c313537c895fcaf1b8ec2ab33593743fee
Cr-Commit-Position: refs/heads/master@{#313196}

Powered by Google App Engine
This is Rietveld 408576698