Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 870123003: Make use of BSS more explicit in global initializers (vs a local .comm). (Closed)

Created:
5 years, 11 months ago by jvoung (off chromium)
Modified:
5 years, 11 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make use of BSS more explicit in global initializers (vs a local .comm). This reduces the number of conditionals, and will more closely reflect the structure of the ELF writer's version of the same thing. Without fdata-sections, the ELF writer version will have to batch all initializers of a certain type so that they can be contiguous on the file and the overall alignment can be determined. A downside of this is that, .s files will be different from llc's output. The spec .o and executables are identical before/after the change. BUG=none R=kschimpf@google.com, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fed97afff11dfdf934a8d3f980651804ddd93586

Patch Set 1 #

Patch Set 2 : local by default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M src/IceTargetLoweringX8632.cpp View 1 2 chunks +9 lines, -16 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvoung (off chromium)
5 years, 11 months ago (2015-01-24 00:20:02 UTC) #2
Jim Stichnoth
lgtm
5 years, 11 months ago (2015-01-24 17:04:00 UTC) #3
Karl
lgtm
5 years, 11 months ago (2015-01-24 17:07:24 UTC) #5
jvoung (off chromium)
5 years, 11 months ago (2015-01-25 18:46:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fed97afff11dfdf934a8d3f980651804ddd93586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698