Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 870103004: Deflake Device Orientation/Motion browsertests. (Closed)

Created:
5 years, 10 months ago by timvolodine
Modified:
5 years, 10 months ago
CC:
chromium-reviews, riju_, Michael van Ouwerkerk, jam, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org, jiayl
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake Device Orientation/Motion browsertests. Currently Device Orientation/Motion null event tests with alert are flaking on some windows and android bots. This patch splits the null event tests into basic tests and one test with modal alert dialog. The latter test ensures that the null events still arrive when active dom objects are suspended (by alert). BUG=360578 Committed: https://crrev.com/34feb66fd7cadba0b35504269cdaa923f79f210d Cr-Commit-Position: refs/heads/master@{#316207}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -109 lines) Patch
M content/browser/device_sensors/device_inertial_sensor_browsertest.cc View 1 2 1 chunk +31 lines, -39 lines 0 comments Download
A content/test/data/device_sensors/device_motion_null_test.html View 1 chunk +37 lines, -0 lines 0 comments Download
D content/test/data/device_sensors/device_motion_null_test_with_alert.html View 1 chunk +0 lines, -38 lines 0 comments Download
A content/test/data/device_sensors/device_orientation_null_test.html View 1 chunk +31 lines, -0 lines 0 comments Download
D content/test/data/device_sensors/device_orientation_null_test_with_alert.html View 1 chunk +0 lines, -32 lines 0 comments Download
A content/test/data/device_sensors/device_sensors_null_test_with_alert.html View 1 2 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
timvolodine
5 years, 10 months ago (2015-02-10 16:41:05 UTC) #2
Andrew Hayden (chromium.org)
LGTM, but it wouldn't hurt my feelings to see a comment in the HTML for ...
5 years, 10 months ago (2015-02-12 14:53:50 UTC) #3
timvolodine
On 2015/02/12 14:53:50, Andrew Hayden wrote: > LGTM, but it wouldn't hurt my feelings to ...
5 years, 10 months ago (2015-02-12 19:40:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870103004/40001
5 years, 10 months ago (2015-02-12 19:46:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24364)
5 years, 10 months ago (2015-02-12 21:03:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870103004/40001
5 years, 10 months ago (2015-02-13 11:43:58 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 12:46:54 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 12:47:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/34feb66fd7cadba0b35504269cdaa923f79f210d
Cr-Commit-Position: refs/heads/master@{#316207}

Powered by Google App Engine
This is Rietveld 408576698