Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: sky/engine/core/rendering/RenderLayerScrollableArea.cpp

Issue 870073003: Remove mouse events from Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/Page.h ('k') | sky/engine/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderLayerScrollableArea.cpp
diff --git a/sky/engine/core/rendering/RenderLayerScrollableArea.cpp b/sky/engine/core/rendering/RenderLayerScrollableArea.cpp
index 25f1b5673dcbf457ffadf93d6309a5f41a48dfa1..ee30cdbe89505ec14cfaff47c54b1e17dc7f974f 100644
--- a/sky/engine/core/rendering/RenderLayerScrollableArea.cpp
+++ b/sky/engine/core/rendering/RenderLayerScrollableArea.cpp
@@ -58,7 +58,6 @@
#include "sky/engine/core/rendering/RenderGeometryMap.h"
#include "sky/engine/core/rendering/RenderView.h"
#include "sky/engine/platform/PlatformGestureEvent.h"
-#include "sky/engine/platform/PlatformMouseEvent.h"
#include "sky/engine/platform/graphics/GraphicsContextStateSaver.h"
#include "sky/engine/platform/scroll/ScrollAnimator.h"
#include "sky/engine/platform/scroll/Scrollbar.h"
@@ -207,8 +206,6 @@ void RenderLayerScrollableArea::setScrollOffset(const IntPoint& newScrollOffset)
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ScrollLayer", "data", InspectorScrollLayerEvent::data(&box()));
- const RenderLayerModelObject* paintInvalidationContainer = box().containerForPaintInvalidation();
-
// Update the positions of our child layers (if needed as only fixed layers should be impacted by a scroll).
// We don't update compositing layers, because we need to do a deep update from the compositing ancestor.
if (!frameView->isInPerformLayout()) {
@@ -220,11 +217,6 @@ void RenderLayerScrollableArea::setScrollOffset(const IntPoint& newScrollOffset)
// The caret rect needs to be invalidated after scrolling
frame->selection().setCaretRectNeedsUpdate();
- // TODO(ojan): Is there a better way to get this value now that we always just pass the empty
- // FloatQuat to localToAbsoluteQuad?
- FloatQuad quadForFakeMouseMoveEvent = paintInvalidationContainer->localToAbsoluteQuad(FloatQuad());
- frame->eventHandler().dispatchFakeMouseMoveEventSoonInQuad(quadForFakeMouseMoveEvent);
ojan 2015/01/23 22:23:06 Have we removed :hover? If not, then this change m
abarth-chromium 2015/01/23 22:39:29 IMHO, we should remove hover for now. We don't ha
-
// Schedule the scroll DOM event.
if (box().node())
box().node()->document().enqueueScrollEventForNode(box().node());
« no previous file with comments | « sky/engine/core/page/Page.h ('k') | sky/engine/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698