Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: chrome/browser/ui/webui/favicon_source.cc

Issue 870063002: Componentize TopSites, TopSitesBackend, TopSitesDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@815983002
Patch Set: Fix typo Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/favicon_source.cc
diff --git a/chrome/browser/ui/webui/favicon_source.cc b/chrome/browser/ui/webui/favicon_source.cc
index badb80a7e671498b31719ebaab8b3294a9479432..1f15edf4aeb733f2ac10a5201a01450af3c1cfa7 100644
--- a/chrome/browser/ui/webui/favicon_source.cc
+++ b/chrome/browser/ui/webui/favicon_source.cc
@@ -10,7 +10,7 @@
#include "base/bind_helpers.h"
#include "base/strings/string_number_conversions.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
-#include "chrome/browser/history/top_sites.h"
+#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search/instant_io_context.h"
#include "chrome/browser/sync/open_tabs_ui_delegate.h"
@@ -19,6 +19,7 @@
#include "chrome/common/favicon/favicon_url_parser.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/locale_settings.h"
+#include "components/history/core/browser/top_sites.h"
#include "net/url_request/url_request.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/layout.h"
@@ -96,17 +97,19 @@ void FaviconSource::StartDataRequest(
callback, url, parsed.size_in_dip, parsed.device_scale_factor)),
&cancelable_task_tracker_);
} else {
- // Intercept requests for prepopulated pages.
- for (int i = 0; i < history::kPrepopulatedPagesCount; i++) {
- if (url.spec() ==
- l10n_util::GetStringUTF8(history::kPrepopulatedPages[i].url_id)) {
- ui::ScaleFactor resource_scale_factor =
- ui::GetSupportedScaleFactor(parsed.device_scale_factor);
- callback.Run(
- ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale(
- history::kPrepopulatedPages[i].favicon_id,
- resource_scale_factor));
- return;
+ // Intercept requests for prepopulated pages if TopSites exists.
+ scoped_refptr<history::TopSites> top_sites =
+ TopSitesFactory::GetForProfile(profile_);
+ if (top_sites) {
+ for (const auto& prepopulated_page : top_sites->GetPrepopulatedPages()) {
+ if (url == prepopulated_page.most_visited.url) {
+ ui::ScaleFactor resource_scale_factor =
+ ui::GetSupportedScaleFactor(parsed.device_scale_factor);
+ callback.Run(
+ ResourceBundle::GetSharedInstance().LoadDataResourceBytesForScale(
+ prepopulated_page.favicon_id, resource_scale_factor));
+ return;
+ }
}
}
« no previous file with comments | « chrome/browser/ui/views/frame/global_menu_bar_x11.cc ('k') | chrome/browser/ui/webui/ntp/favicon_webui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698