Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870053004: Make URL constructor failure throw TypeError (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make URL constructor failure throw TypeError Throw TypeError for invalid URL or base URL parameters as specified here: https://url.spec.whatwg.org/#dom-url-url BUG=435006 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188923

Patch Set 1 #

Patch Set 2 : Change test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M LayoutTests/fast/domurl/url-constructor.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/DOMURL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
5 years, 11 months ago (2015-01-23 22:55:37 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 11 months ago (2015-01-23 23:03:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870053004/20001
5 years, 11 months ago (2015-01-23 23:26:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/47585)
5 years, 11 months ago (2015-01-24 02:05:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870053004/20001
5 years, 11 months ago (2015-01-24 02:41:14 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 03:33:12 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188923

Powered by Google App Engine
This is Rietveld 408576698