Issue 870053002: Further instrumentations of QuicStreamFactory::CreateSession to find janks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 870053002: Further instrumentations of QuicStreamFactory::CreateSession to find janks (Closed)

Created:
5 years, 11 months ago by vadimt

Modified:
5 years, 11 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Further instrumentations of QuicStreamFactory::CreateSession to find janks Jankiness of "422516 QuicStreamFactory::CreateSession57" is 35 jph. Instrumenting further. BUG=422516 Committed: https://crrev.com/42d64204f7cc2abd1ceb582f12d8bb77562657d8 Cr-Commit-Position: refs/heads/master@{#312878}

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	net/quic/quic_client_session.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	net/quic/quic_stream_factory.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vadimt

rtenneti@, please review. Will also appreciate additional instrumentations ideas.

5 years, 11 months ago (2015-01-23 17:04:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870053002/1

5 years, 11 months ago (2015-01-23 17:10:43 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-23 18:18:06 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/42d64204f7cc2abd1ceb582f12d8bb77562657d8
Cr-Commit-Position: refs/heads/master@{#312878}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages