Source/core/layout/LayoutBox.h - Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.h

Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: ResolveConflict Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutBox.h

diff --git a/Source/core/layout/LayoutBox.h b/Source/core/layout/LayoutBox.h

index 3e562d0c8dfa1c4b5df5678a11e62ea0d151c0da..2c716cf0c4bcec444e5425fb25547e2a084de1dd 100644

--- a/Source/core/layout/LayoutBox.h

+++ b/Source/core/layout/LayoutBox.h

@@ -108,6 +108,12 @@ public:

int pixelSnappedLogicalHeight() const { return style()->isHorizontalWritingMode() ? pixelSnappedHeight() : pixelSnappedWidth(); }

int pixelSnappedLogicalWidth() const { return style()->isHorizontalWritingMode() ? pixelSnappedWidth() : pixelSnappedHeight(); }

+ LayoutUnit minimumLogicalHeightForEmptyLine() const

+ {

+ return borderAndPaddingLogicalHeight() + scrollbarLogicalHeight()

+ + lineHeight(true, isHorizontalWritingMode() ? HorizontalLine : VerticalLine, PositionOfInteriorLineBoxes);

+ }

void setLogicalLeft(LayoutUnit left)

{

if (style()->isHorizontalWritingMode())

« no previous file with comments | « Source/core/dom/Position.cpp ('k') | Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »