LayoutTests/fast/events/key-events-in-editable-gridbox.html - Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/key-events-in-editable-gridbox.html

Issue 870013003: Div having contentEditable and display:grid cannot be edited if it is empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add minimumLogicalHeightForEmptyLine Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	rune 2015/02/26 10:38:50 html, head, and body should be left out when not n html, head, and body should be left out when not necessary. changseok 2015/02/26 11:28:54 Done. Show quoted text On 2015/02/26 10:38:50, rune wrote: > html, head, and body should be left out when not necessary. Done.
	4 <script src="../../resources/js-test.js"></script>

	5 <style>

	6 #target {

	7 display: grid;

	8 display: -webkit-grid;

	9 }

	10 </style>

	11 <script>

	12 var targetDiv;

	13 function test()

	14 {

	15 targetDiv = document.getElementById('target');

	16 targetDiv.focus();

	17

	18 // Move cursor to the end of line.

	19 getSelection().modify('move', 'forward', 'lineboundary');

	20

	21 document.execCommand("insertText", false, "EST");

	22 shouldBeEqualToString("targetDiv.innerText", "TEST");

	23

	24 document.execCommand("delete");

	25 document.execCommand("delete");

	26 document.execCommand("delete");

	27 document.execCommand("delete");

	28 shouldBeEmptyString("targetDiv.innerText");

	29

	30 document.execCommand("insertText", false, "TEST");

	31 shouldBeEqualToString("targetDiv.innerText", "TEST");

	32 }
	rune 2015/02/26 10:38:50 You shouldn't need to wait for an onload here? Cou You shouldn't need to wait for an onload here? Couldn't this test be run directly if you move the div#target element above the script? changseok 2015/02/26 11:28:54 You're right. Done. Show quoted text On 2015/02/26 10:38:50, rune wrote: > You shouldn't need to wait for an onload here? Couldn't this test be run > directly if you move the div#target element above the script? You're right. Done.
	33 </script>

	34 </head>

	35 <body onload="test()">

	36 <div id="target" contentEditable>T</div>

	37 </body>

	38 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/key-events-in-editable-gridbox-expected.txt » ('j') | Source/core/rendering/RenderBox.h » ('J')