Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 869993003: Added test for proxy auth dialog on sign-in screen. (Closed)

Created:
5 years, 11 months ago by ygorshenin1
Modified:
5 years, 11 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added test for proxy auth dialog on sign-in screen. BUG=330607 TEST=browser_tests:ProxyAuthOnUserBoardScreenTest.* Committed: https://crrev.com/5bd81402de4e930479ed6995ff6b42196a47282b Cr-Commit-Position: refs/heads/master@{#313048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
A chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc View 1 chunk +123 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ygorshenin1
5 years, 11 months ago (2015-01-23 14:18:12 UTC) #2
Nikita (slow)
lgtm
5 years, 11 months ago (2015-01-26 07:03:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869993003/1
5 years, 11 months ago (2015-01-26 07:04:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 08:31:32 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 08:32:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5bd81402de4e930479ed6995ff6b42196a47282b
Cr-Commit-Position: refs/heads/master@{#313048}

Powered by Google App Engine
This is Rietveld 408576698