Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 869963002: Reland "Call directly to c callbacks in Invoke instead of transitioning to js and back out" (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Call directly to c callbacks in Invoke instead of transitioning to js and back out" BUG= Committed: https://crrev.com/8a78fd6d2e9fceee5ea790b6e211c006718dc655 Cr-Commit-Position: refs/heads/master@{#26245}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -18 lines) Patch
M src/arguments.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 5 chunks +80 lines, -18 lines 0 comments Download
M src/execution.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-23 10:51:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869963002/20001
5 years, 11 months ago (2015-01-23 10:52:28 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 11:22:12 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 11:22:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a78fd6d2e9fceee5ea790b6e211c006718dc655
Cr-Commit-Position: refs/heads/master@{#26245}

Powered by Google App Engine
This is Rietveld 408576698