Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 869933005: Add DumpAccessibilityTree tests (15,20 of 20) (Closed)

Created:
5 years, 10 months ago by shreeramk
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DumpAccessibilityTree tests (15,20 of 20) BUG=170587, 170592 NOTRY=true Committed: https://crrev.com/81689334d2475fd477856afb40a9e43245e45245 Cr-Commit-Position: refs/heads/master@{#314343}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : uploading expectations #

Total comments: 2

Patch Set 4 : #

Total comments: 2

Patch Set 5 : skipping aria-selected on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -52 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 6 chunks +36 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-grid.html View 2 chunks +5 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-grid-expected-android.txt View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
A content/test/data/accessibility/aria/aria-grid-expected-mac.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-grid-expected-win.txt View 1 chunk +4 lines, -9 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-gridcell.html View 2 chunks +5 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-gridcell-expected-android.txt View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
A content/test/data/accessibility/aria/aria-gridcell-expected-mac.txt View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-gridcell-expected-win.txt View 1 chunk +4 lines, -9 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-group.html View 1 chunk +3 lines, -4 lines 0 comments Download
A content/test/data/accessibility/aria/aria-group-expected-android.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-group-expected-mac.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-group-expected-win.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria/aria-selected.html View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-selected-expected-android.txt View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria/aria-selected-expected-mac.txt View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M content/test/data/accessibility/aria/aria-selected-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A content/test/data/accessibility/aria/aria-tabpanel.html View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-tabpanel-expected-android.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-tabpanel-expected-mac.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-tabpanel-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/b.html View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/b-expected-android.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/html/b-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/html/b-expected-win.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + content/test/data/accessibility/html/base.html View 1 chunk +1 line, -2 lines 0 comments Download
A + content/test/data/accessibility/html/base-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/base-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/base-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/html/input-hidden.html View 1 chunk +6 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/input-hidden-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/input-hidden-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/input-hidden-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/html/input-password.html View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
A + content/test/data/accessibility/html/input-password-expected-android.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + content/test/data/accessibility/html/input-password-expected-mac.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/html/input-password-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/html/small.html View 1 chunk +8 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/small-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/html/small-expected-mac.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/html/small-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
shreeramk
Please review. Thanks!
5 years, 10 months ago (2015-02-02 07:43:30 UTC) #2
dmazzoni
lgtm Great! Go ahead and submit after addressing the two things below on Mac. If ...
5 years, 10 months ago (2015-02-02 21:28:07 UTC) #3
shreeramk
https://codereview.chromium.org/869933005/diff/60001/content/test/data/accessibility/aria/aria-selected-expected-mac.txt File content/test/data/accessibility/aria/aria-selected-expected-mac.txt (right): https://codereview.chromium.org/869933005/diff/60001/content/test/data/accessibility/aria/aria-selected-expected-mac.txt#newcode2 content/test/data/accessibility/aria/aria-selected-expected-mac.txt:2: AXList AXSelectedChildren=["AXStaticText 1"] On Mac, the code expose AXSelectedChildren ...
5 years, 10 months ago (2015-02-03 04:26:48 UTC) #4
dmazzoni
https://codereview.chromium.org/869933005/diff/60001/content/test/data/accessibility/aria/aria-selected-expected-mac.txt File content/test/data/accessibility/aria/aria-selected-expected-mac.txt (right): https://codereview.chromium.org/869933005/diff/60001/content/test/data/accessibility/aria/aria-selected-expected-mac.txt#newcode2 content/test/data/accessibility/aria/aria-selected-expected-mac.txt:2: AXList AXSelectedChildren=["AXStaticText 1"] On 2015/02/03 04:26:48, shreeramk wrote: > ...
5 years, 10 months ago (2015-02-03 06:41:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869933005/80001
5 years, 10 months ago (2015-02-03 13:06:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/51409)
5 years, 10 months ago (2015-02-03 14:59:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869933005/80001
5 years, 10 months ago (2015-02-03 16:13:08 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-03 16:14:32 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:16:11 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/81689334d2475fd477856afb40a9e43245e45245
Cr-Commit-Position: refs/heads/master@{#314343}

Powered by Google App Engine
This is Rietveld 408576698