Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 86993002: Assume Document may be HtmlDocument (Closed)

Created:
7 years ago by sra1
Modified:
7 years ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Assume Document may be HtmlDocument Committed: https://code.google.com/p/dart/source/detail?r=30740

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M sdk/lib/_internal/lib/native_helper.dart View 1 4 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sra1
Siggi, try this to see if it cures your 'Document' problem. If so, I will ...
7 years ago (2013-11-26 03:08:54 UTC) #1
Siggi Cherem (dart-lang)
Thanks Stephen, seems to work for me locally when running in chrome. I updated https://code.google.com/p/dart/issues/detail?id=14720 ...
7 years ago (2013-11-27 02:34:33 UTC) #2
ahe
DBC https://codereview.chromium.org/86993002/diff/1/sdk/lib/_internal/lib/native_helper.dart File sdk/lib/_internal/lib/native_helper.dart (right): https://codereview.chromium.org/86993002/diff/1/sdk/lib/_internal/lib/native_helper.dart#newcode577 sdk/lib/_internal/lib/native_helper.dart:577: Extra line. https://codereview.chromium.org/86993002/diff/1/sdk/lib/_internal/lib/native_helper.dart#newcode605 sdk/lib/_internal/lib/native_helper.dart:605: Extra line.
7 years ago (2013-11-27 09:54:10 UTC) #3
sra1
Committed patchset #2 manually as r30740 (presubmit successful).
7 years ago (2013-11-28 01:23:57 UTC) #4
Siggi Cherem (dart-lang)
7 years ago (2013-11-28 01:25:51 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698