Issue 869903002: Oilpan: fix build after r188851.

Issue 869903002: Oilpan: fix build after r188851. (Closed)

Created:
5 years, 11 months ago by sof

Modified:
5 years, 11 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Oilpan: fix build after r188851. Move FetchManager::Loader to the heap as ContextLifecycleObserver are now GC mixins. R=haraken BUG=451288 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188864

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -8 lines)			Patch
	M	Source/modules/fetch/FetchManager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/modules/fetch/FetchManager.cpp	View	1 2	6 chunks	+30 lines, -7 lines	0 comments	Download

Total messages: 7 (2 generated)

sof

Please take a look. When is Member<> useful/allowable in a class without a GC base?

5 years, 11 months ago (2015-01-23 06:58:19 UTC) #2

haraken

LGTM > When is Member<> useful/allowable in a class without a GC base? Member<> is ...

5 years, 11 months ago (2015-01-23 07:06:46 UTC) #3

sof

On 2015/01/23 07:06:46, haraken wrote: > LGTM > > > When is Member<> useful/allowable in ...

5 years, 11 months ago (2015-01-23 07:10:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869903002/40001

5 years, 11 months ago (2015-01-23 07:13:48 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2015-01-23 07:14:16 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188864