Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ppapi/shared_impl/proxy_lock.h

Issue 869883003: Never lock the Pepper proxy lock on the IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: oops, version without the TrackedCallback changes. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ppapi/proxy/udp_socket_resource_base.cc ('K') | « ppapi/shared_impl/callback_tracker.cc ('k') | ppapi/shared_impl/tracked_callback.cc » ('j') | ppapi/shared_impl/tracked_callback.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/shared_impl/proxy_lock.h
diff --git a/ppapi/shared_impl/proxy_lock.h b/ppapi/shared_impl/proxy_lock.h
index 39b653e1a00bccb49217f9b494d4d5a666d5a67d..7fcf2cf23b2958f661fd8748b57c3a1806cc26f3 100644
--- a/ppapi/shared_impl/proxy_lock.h
+++ b/ppapi/shared_impl/proxy_lock.h
@@ -175,9 +175,6 @@ class RunWhileLockedHelper<void()> {
typedef base::Callback<void()> CallbackType;
explicit RunWhileLockedHelper(const CallbackType& callback)
: callback_(new CallbackType(callback)) {
- // Copying |callback| may adjust reference counts for bound Vars or
- // Resources; we should have the lock already.
- ProxyLock::AssertAcquired();
// CallWhileLocked and destruction might happen on a different thread from
// creation.
thread_checker_.DetachFromThread();
@@ -268,7 +265,6 @@ class RunWhileLockedHelper<void(P1, P2)> {
typedef base::Callback<void(P1, P2)> CallbackType;
explicit RunWhileLockedHelper(const CallbackType& callback)
: callback_(new CallbackType(callback)) {
- ProxyLock::AssertAcquired();
thread_checker_.DetachFromThread();
}
void CallWhileLocked(P1 p1, P2 p2) {
@@ -298,7 +294,6 @@ class RunWhileLockedHelper<void(P1, P2, P3)> {
typedef base::Callback<void(P1, P2, P3)> CallbackType;
explicit RunWhileLockedHelper(const CallbackType& callback)
: callback_(new CallbackType(callback)) {
- ProxyLock::AssertAcquired();
thread_checker_.DetachFromThread();
}
void CallWhileLocked(P1 p1, P2 p2, P3 p3) {
« ppapi/proxy/udp_socket_resource_base.cc ('K') | « ppapi/shared_impl/callback_tracker.cc ('k') | ppapi/shared_impl/tracked_callback.cc » ('j') | ppapi/shared_impl/tracked_callback.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698