ppapi/shared_impl/callback_tracker.cc - Issue 869883003: Never lock the Pepper proxy lock on the IO thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/callback_tracker.cc

Issue 869883003: Never lock the Pepper proxy lock on the IO thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some pre-review cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/callback_tracker.cc

diff --git a/ppapi/shared_impl/callback_tracker.cc b/ppapi/shared_impl/callback_tracker.cc

index de519a13f71be385d41a8f0cfd940fe3084402f2..cfc66f6f66da19959f24cc25a8af6f55243d308a 100644

--- a/ppapi/shared_impl/callback_tracker.cc

+++ b/ppapi/shared_impl/callback_tracker.cc

@@ -52,9 +52,8 @@ void CallbackTracker::PostAbortForResource(PP_Resource resource_id) {

// TrackedCallback.

callbacks_for_resource = iter->second;

}

- for (const auto& iter : callbacks_for_resource) {

+ for (const auto& iter : callbacks_for_resource)

iter->PostAbort();

- }

}

CallbackTracker::~CallbackTracker() {