chrome/browser/ui/views/location_bar/page_action_image_view.h - Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_action_image_view.h

Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Avi's Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc ('k') | chrome/browser/ui/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/page_action_image_view.h

diff --git a/chrome/browser/ui/views/location_bar/page_action_image_view.h b/chrome/browser/ui/views/location_bar/page_action_image_view.h

index 5f3785cd607c0af8b53ff92754d105d0a95e4827..7aa987f3a4878c4b5c2857ee9996d66e1aa8da14 100644

--- a/chrome/browser/ui/views/location_bar/page_action_image_view.h

+++ b/chrome/browser/ui/views/location_bar/page_action_image_view.h

@@ -70,7 +70,6 @@ class PageActionImageView : public ToolbarActionViewDelegateViews,

views::View* GetReferenceViewForPopup() override;

views::MenuButton* GetContextMenuButton() override;

content::WebContents* GetCurrentWebContents() const override;

- void HideActivePopup() override;

// The controller for this ExtensionAction view.

scoped_ptr<ExtensionActionViewController> view_controller_;