chrome/browser/ui/views/toolbar/browser_actions_container.h - Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.h

Issue 869873008: [Extensions Toolbar] Move some popup logic to be platform-agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/extension_action_view_controller.cc ('K') | « chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_action_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/browser_actions_container.h

diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.h b/chrome/browser/ui/views/toolbar/browser_actions_container.h

index 43919d3e5040456cc1f1916e42a0af01e1b5886e..3efc59a1645b9400a1e8f59b359b65c2d0262365 100644

--- a/chrome/browser/ui/views/toolbar/browser_actions_container.h

+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.h

@@ -187,6 +187,9 @@ class BrowserActionsContainer

void ExecuteExtensionCommand(const extensions::Extension* extension,

const extensions::Command& command);

+ // Hides the currently-active popup, if there is one.

+ void HideActivePopup();

// Add or remove an observer.

void AddObserver(BrowserActionsContainerObserver* observer);

void RemoveObserver(BrowserActionsContainerObserver* observer);

@@ -229,7 +232,6 @@ class BrowserActionsContainer

void OnToolbarActionViewDragDone() override;

views::MenuButton* GetOverflowReferenceView() override;

void SetPopupOwner(ToolbarActionView* popup_owner) override;

- void HideActivePopup() override;

ToolbarActionView* GetMainViewForAction(ToolbarActionView* view) override;

// ToolbarActionsBarDelegate: