Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 869873005: Refactor //mojo/PRESUBMIT_tests.py (Closed)

Created:
5 years, 10 months ago by blundell
Modified:
5 years, 10 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Refactor //mojo/PRESUBMIT_tests.py This change is in preparation for adding checks on services' public buildfiles to //mojo/PRESUBMIT.py. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4dc8a11d31cfa35620278cf652adbb6a68e39461

Patch Set 1 #

Patch Set 2 : Remove cruft #

Total comments: 2

Patch Set 3 : Response to review #

Total comments: 2

Patch Set 4 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -51 lines) Patch
M mojo/PRESUBMIT_test.py View 1 2 3 6 chunks +67 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
blundell
5 years, 10 months ago (2015-01-28 14:50:29 UTC) #2
qsr
https://codereview.chromium.org/869873005/diff/20001/mojo/PRESUBMIT_test.py File mojo/PRESUBMIT_test.py (right): https://codereview.chromium.org/869873005/diff/20001/mojo/PRESUBMIT_test.py#newcode21 mojo/PRESUBMIT_test.py:21: "SDK" : _SDK_BUILD_FILE, You need 4 char indentation here.
5 years, 10 months ago (2015-01-28 15:01:37 UTC) #3
blundell
https://codereview.chromium.org/869873005/diff/20001/mojo/PRESUBMIT_test.py File mojo/PRESUBMIT_test.py (right): https://codereview.chromium.org/869873005/diff/20001/mojo/PRESUBMIT_test.py#newcode21 mojo/PRESUBMIT_test.py:21: "SDK" : _SDK_BUILD_FILE, On 2015/01/28 15:01:37, qsr wrote: > ...
5 years, 10 months ago (2015-01-28 15:20:28 UTC) #4
qsr
LGTM with nits. https://codereview.chromium.org/869873005/diff/40001/mojo/PRESUBMIT_test.py File mojo/PRESUBMIT_test.py (right): https://codereview.chromium.org/869873005/diff/40001/mojo/PRESUBMIT_test.py#newcode21 mojo/PRESUBMIT_test.py:21: "SDK" : _SDK_BUILD_FILE, This file seems ...
5 years, 10 months ago (2015-01-28 15:26:01 UTC) #5
blundell
https://codereview.chromium.org/869873005/diff/40001/mojo/PRESUBMIT_test.py File mojo/PRESUBMIT_test.py (right): https://codereview.chromium.org/869873005/diff/40001/mojo/PRESUBMIT_test.py#newcode21 mojo/PRESUBMIT_test.py:21: "SDK" : _SDK_BUILD_FILE, On 2015/01/28 15:26:01, qsr wrote: > ...
5 years, 10 months ago (2015-01-28 15:39:47 UTC) #6
blundell
5 years, 10 months ago (2015-01-28 15:40:05 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4dc8a11d31cfa35620278cf652adbb6a68e39461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698