Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 869853004: Remove stray newline in tracing.zip filename (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
dnicoara, achaulk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stray newline in tracing.zip filename The uploaded trace is currently inaccessible because of the stray newline. BUG=455782 TEST=upload a feedback report with trace & download tracing.zip Committed: https://crrev.com/14a9aedeebbbc06a23af0087796fb48b4103b3f6 Cr-Commit-Position: refs/heads/master@{#314858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/feedback/feedback_data.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
spang
5 years, 10 months ago (2015-02-05 18:13:29 UTC) #2
achaulk
lgtm it's been like that for years, guess nobody noticed before...
5 years, 10 months ago (2015-02-05 18:56:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869853004/1
5 years, 10 months ago (2015-02-05 19:00:06 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-05 19:00:08 UTC) #7
dnicoara
lgtm
5 years, 10 months ago (2015-02-05 19:02:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869853004/1
5 years, 10 months ago (2015-02-05 19:03:49 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 19:53:00 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 19:53:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14a9aedeebbbc06a23af0087796fb48b4103b3f6
Cr-Commit-Position: refs/heads/master@{#314858}

Powered by Google App Engine
This is Rietveld 408576698