Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 869853003: Cherry pick final avx[2] detection code (Closed)

Created:
5 years, 11 months ago by Johann
Modified:
5 years, 11 months ago
Reviewers:
jzern, Tom Finegan
CC:
wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cherry pick final avx[2] detection code https://gerrit.chromium.org/gerrit/73502 https://gerrit.chromium.org/gerrit/73581 The original implementation of the avx2 detection appeared to lock up WinXP/Vista bots. Pull the final version which guards the xgetbv call with the cpu flags for both 256-bit AVX *and* OSXSAVE. Theory is that AVX was declared available by the cpuid call (bit 28) but the OS did not support it (as would be indicated by OSXSAVE being unset). The check was incomplete and allowed it to step forward to the next checks: xgetbv and cpuid for leaf 7 feature flags. One of those (most likely xgetbv since the leaf 7 check has been there for a while) causes the process to hang and the tests to time out. That's the theory anyway. R=tomfinegan@chromium.org, jzern@chromium.org CC=bmeurer@chromium.org Committed: cf86fa704b0d6da24d1a9adb36001f9bc5df351f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
M source/libvpx/vpx_ports/x86.h View 3 chunks +41 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Tom Finegan
lgtm
5 years, 11 months ago (2015-01-27 19:00:44 UTC) #1
Johann
5 years, 11 months ago (2015-01-27 20:53:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cf86fa704b0d6da24d1a9adb36001f9bc5df351f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698