Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 869843002: Revive the upload script for the network service. (Closed)

Created:
5 years, 11 months ago by ppi
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revive the upload script for the network service. This updates the upload_network_service.py so that: - binaries for android-arm can be uploaded too - a zip of the mojom interfaces is uploaded along the binaries BUG=450356 Committed: https://crrev.com/b3b0450905b9da1a3c6a997773d84d7f6727b3cd Cr-Commit-Position: refs/heads/master@{#312754}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M mojo/services/network/upload_network_service.py View 1 3 chunks +44 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ppi
Hi James, ptal.
5 years, 11 months ago (2015-01-23 01:05:40 UTC) #2
jamesr
lgtm
5 years, 11 months ago (2015-01-23 01:14:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869843002/20001
5 years, 11 months ago (2015-01-23 01:17:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 03:17:04 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 03:19:38 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3b0450905b9da1a3c6a997773d84d7f6727b3cd
Cr-Commit-Position: refs/heads/master@{#312754}

Powered by Google App Engine
This is Rietveld 408576698