Source/core/layout/line/InlineTextBox.cpp - Issue 869813003: Implement elementsFromPoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/InlineTextBox.cpp

Issue 869813003: Implement elementsFromPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Cleanup, add a better test for tables Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/line/InlineTextBox.cpp

diff --git a/Source/core/layout/line/InlineTextBox.cpp b/Source/core/layout/line/InlineTextBox.cpp

index 531dcacf811ca0a7d741c11582f641d7fb5a749a..4c7e5a8e9f8df42638cfc6a5540a4f6ee190cff3 100644

--- a/Source/core/layout/line/InlineTextBox.cpp

+++ b/Source/core/layout/line/InlineTextBox.cpp

@@ -323,7 +323,7 @@ bool InlineTextBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& re

// to LayoutUnit-based types is complete (crbug.com/321237)

if (m_truncation != cFullTruncation && visibleToHitTestRequest(request) && locationInContainer.intersects(rect.rawValue())) {

renderer().updateHitTestResult(result, flipForWritingMode(locationInContainer.point() - toLayoutSize(accumulatedOffset)));

- if (!result.addNodeToRectBasedTestResult(renderer().node(), request, locationInContainer, rect.rawValue()))

+ if (!result.addNodeToListBasedTestResult(renderer().node(), request, locationInContainer, rect.rawValue()))

return true;

}

return false;

« no previous file with comments | « Source/core/layout/line/InlineFlowBox.cpp ('k') | Source/core/layout/svg/LayoutSVGRoot.cpp » ('j') | no next file with comments »