Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: Source/core/layout/HitTestResult.h

Issue 869813003: Implement elementsFromPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Cleanup, add a better test for tables Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/HitTestRequest.h ('k') | Source/core/layout/HitTestResult.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/HitTestResult.h
diff --git a/Source/core/layout/HitTestResult.h b/Source/core/layout/HitTestResult.h
index 093855d026f48fc6d914d717a41c4f47858ba8a4..2f763e3f92280ccd2d5aca4935b7cdb031e22972 100644
--- a/Source/core/layout/HitTestResult.h
+++ b/Source/core/layout/HitTestResult.h
@@ -117,22 +117,22 @@ public:
bool isContentEditable() const;
bool isOverLink() const;
- // Returns true if it is rect-based hit test and needs to continue until the rect is fully
- // enclosed by the boundaries of a node.
- bool addNodeToRectBasedTestResult(Node*, const HitTestRequest&, const HitTestLocation& pointInContainer, const LayoutRect& = LayoutRect());
- bool addNodeToRectBasedTestResult(Node*, const HitTestRequest&, const HitTestLocation& pointInContainer, const FloatRect&);
- void append(const HitTestResult&);
- // If m_rectBasedTestResult is 0 then set it to a new NodeSet. Return *m_rectBasedTestResult. Lazy allocation makes
+ // Return true if the test is a list-based test and we should continue testing.
+ bool addNodeToListBasedTestResult(Node*, const HitTestRequest&, const HitTestLocation& pointInContainer, const LayoutRect& = LayoutRect());
+ bool addNodeToListBasedTestResult(Node*, const HitTestRequest&, const HitTestLocation& pointInContainer, const FloatRect&);
+ void append(const HitTestResult&, const HitTestRequest&);
+
+ // If m_listBasedTestResult is 0 then set it to a new NodeSet. Return *m_listBasedTestResult. Lazy allocation makes
// sense because the NodeSet is seldom necessary, and it's somewhat expensive to allocate and initialize. This method does
- // the same thing as mutableRectBasedTestResult(), but here the return value is const.
- const NodeSet& rectBasedTestResult() const;
+ // the same thing as mutableListBasedTestResult(), but here the return value is const.
+ const NodeSet& listBasedTestResult() const;
// Collapse the rect-based test result into a single target at the specified location.
void resolveRectBasedTest(Node* resolvedInnerNode, const LayoutPoint& resolvedPointInMainFrame);
private:
- NodeSet& mutableRectBasedTestResult(); // See above.
+ NodeSet& mutableListBasedTestResult(); // See above.
HTMLMediaElement* mediaElement() const;
HitTestLocation m_hitTestLocation;
@@ -148,7 +148,7 @@ private:
RefPtrWillBeMember<Scrollbar> m_scrollbar;
bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a LayoutPart for example).
- mutable OwnPtrWillBeMember<NodeSet> m_rectBasedTestResult;
+ mutable OwnPtrWillBeMember<NodeSet> m_listBasedTestResult;
};
} // namespace blink
« no previous file with comments | « Source/core/layout/HitTestRequest.h ('k') | Source/core/layout/HitTestResult.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698