Source/core/layout/line/InlineFlowBox.cpp - Issue 869813003: Implement elementsFromPoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/InlineFlowBox.cpp

Issue 869813003: Implement elementsFromPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix Internals.cpp for touch adjustment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/events/elementsFromPoint-invalid-cases-expected.txt ('K') | « Source/core/layout/line/EllipsisBox.cpp ('k') | Source/core/layout/line/InlineTextBox.cpp » ('j') | Source/core/page/EventHandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/line/InlineFlowBox.cpp

diff --git a/Source/core/layout/line/InlineFlowBox.cpp b/Source/core/layout/line/InlineFlowBox.cpp

index cfb005de3fcc87755fec38744a5aaae2e7cf37f2..5999004ce4f41b9c725db972f29c27cf66c41705 100644

--- a/Source/core/layout/line/InlineFlowBox.cpp

+++ b/Source/core/layout/line/InlineFlowBox.cpp

@@ -1071,7 +1071,7 @@ bool InlineFlowBox::nodeAtPoint(const HitTestRequest& request, HitTestResult& re

if (visibleToHitTestRequest(request) && locationInContainer.intersects(rect)) {

renderer().updateHitTestResult(result, flipForWritingMode(locationInContainer.point() - toLayoutSize(accumulatedOffset))); // Don't add in m_x or m_y here, we want coords in the containing block's space.

- if (!result.addNodeToRectBasedTestResult(renderer().node(), request, locationInContainer, rect))

+ if (!result.addNodeToListBasedTestResult(renderer().node(), request, locationInContainer, rect))

return true;

}