Source/core/page/TouchDisambiguation.cpp - Issue 869813003: Implement elementsFromPoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/TouchDisambiguation.cpp

Issue 869813003: Implement elementsFromPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix typeo Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/TouchDisambiguation.cpp

diff --git a/Source/core/page/TouchDisambiguation.cpp b/Source/core/page/TouchDisambiguation.cpp

index d6fd118e4351a413d117ce949e203e21a4be174f..88fa20270e5addf604ba635924a00a0aa06bdb6f 100644

--- a/Source/core/page/TouchDisambiguation.cpp

+++ b/Source/core/page/TouchDisambiguation.cpp

@@ -95,8 +95,8 @@ void findGoodTouchTargets(const IntRect& touchBox, LocalFrame* mainFrame, Vector

IntPoint touchPoint = touchBox.center();

IntPoint contentsPoint = mainFrame->view()->windowToContents(touchPoint);

- HitTestResult result = mainFrame->eventHandler().hitTestResultAtPoint(contentsPoint, HitTestRequest::ReadOnly | HitTestRequest::Active, LayoutSize(touchPointPadding, touchPointPadding));

- const WillBeHeapListHashSet<RefPtrWillBeMember<Node>>& hitResults = result.rectBasedTestResult();

+ HitTestResult result = mainFrame->eventHandler().hitTestResultAtPoint(contentsPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::ListBased, LayoutSize(touchPointPadding, touchPointPadding));

+ const WillBeHeapListHashSet<RefPtrWillBeMember<Node>>& hitResults = result.listBasedTestResult();

// Blacklist nodes that are container of disambiguated nodes.

// It is not uncommon to have a clickable <div> that contains other clickable objects.

« Source/core/page/EventHandler.cpp ('K') | « Source/core/page/EventHandler.cpp ('k') | Source/core/rendering/EllipsisBox.cpp » ('j') | Source/core/rendering/HitTestRequest.h » ('J')