Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: Source/core/layout/svg/LayoutSVGRoot.cpp

Issue 869813003: Implement elementsFromPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Cleanup, add a better test for tables Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008, 2009 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. 5 * Copyright (C) 2009 Google, Inc.
6 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 // FIXME: This should be an intersection when rect-based hit tests are suppo rted by nodeAtFloatPoint. 400 // FIXME: This should be an intersection when rect-based hit tests are suppo rted by nodeAtFloatPoint.
401 if (contentBoxRect().contains(pointInBorderBox) || (!shouldApplyViewportClip () && visualOverflowRect().contains(pointInBorderBox))) { 401 if (contentBoxRect().contains(pointInBorderBox) || (!shouldApplyViewportClip () && visualOverflowRect().contains(pointInBorderBox))) {
402 const AffineTransform& localToParentTransform = this->localToParentTrans form(); 402 const AffineTransform& localToParentTransform = this->localToParentTrans form();
403 if (localToParentTransform.isInvertible()) { 403 if (localToParentTransform.isInvertible()) {
404 FloatPoint localPoint = localToParentTransform.inverse().mapPoint(Fl oatPoint(pointInParent)); 404 FloatPoint localPoint = localToParentTransform.inverse().mapPoint(Fl oatPoint(pointInParent));
405 405
406 for (LayoutObject* child = lastChild(); child; child = child->previo usSibling()) { 406 for (LayoutObject* child = lastChild(); child; child = child->previo usSibling()) {
407 // FIXME: nodeAtFloatPoint() doesn't handle rect-based hit tests yet. 407 // FIXME: nodeAtFloatPoint() doesn't handle rect-based hit tests yet.
408 if (child->nodeAtFloatPoint(request, result, localPoint, hitTest Action)) { 408 if (child->nodeAtFloatPoint(request, result, localPoint, hitTest Action)) {
409 updateHitTestResult(result, pointInBorderBox); 409 updateHitTestResult(result, pointInBorderBox);
410 if (!result.addNodeToRectBasedTestResult(child->node(), requ est, locationInContainer)) 410 if (!result.addNodeToListBasedTestResult(child->node(), requ est, locationInContainer))
411 return true; 411 return true;
412 } 412 }
413 } 413 }
414 } 414 }
415 } 415 }
416 416
417 // If we didn't early exit above, we've just hit the container <svg> element . Unlike SVG 1.1, 2nd Edition allows container elements to be hit. 417 // If we didn't early exit above, we've just hit the container <svg> element . Unlike SVG 1.1, 2nd Edition allows container elements to be hit.
418 if ((hitTestAction == HitTestBlockBackground || hitTestAction == HitTestChil dBlockBackground) && visibleToHitTestRequest(request)) { 418 if ((hitTestAction == HitTestBlockBackground || hitTestAction == HitTestChil dBlockBackground) && visibleToHitTestRequest(request)) {
419 // Only return true here, if the last hit testing phase 'BlockBackground ' (or 'ChildBlockBackground' - depending on context) is executed. 419 // Only return true here, if the last hit testing phase 'BlockBackground ' (or 'ChildBlockBackground' - depending on context) is executed.
420 // If we'd return true in the 'Foreground' phase, hit testing would stop immediately. For SVG only trees this doesn't matter. 420 // If we'd return true in the 'Foreground' phase, hit testing would stop immediately. For SVG only trees this doesn't matter.
421 // Though when we have a <foreignObject> subtree we need to be able to d etect hits on the background of a <div> element. 421 // Though when we have a <foreignObject> subtree we need to be able to d etect hits on the background of a <div> element.
422 // If we'd return true here in the 'Foreground' phase, we are not able t o detect these hits anymore. 422 // If we'd return true here in the 'Foreground' phase, we are not able t o detect these hits anymore.
423 LayoutRect boundsRect(accumulatedOffset + location(), size()); 423 LayoutRect boundsRect(accumulatedOffset + location(), size());
424 if (locationInContainer.intersects(boundsRect)) { 424 if (locationInContainer.intersects(boundsRect)) {
425 updateHitTestResult(result, pointInBorderBox); 425 updateHitTestResult(result, pointInBorderBox);
426 if (!result.addNodeToRectBasedTestResult(node(), request, locationIn Container, boundsRect)) 426 if (!result.addNodeToListBasedTestResult(node(), request, locationIn Container, boundsRect))
427 return true; 427 return true;
428 } 428 }
429 } 429 }
430 430
431 return false; 431 return false;
432 } 432 }
433 433
434 } 434 }
OLDNEW
« no previous file with comments | « Source/core/layout/line/InlineTextBox.cpp ('k') | Source/core/layout/svg/line/SVGInlineTextBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698