Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: Source/core/layout/LayoutTableSection.cpp

Issue 869813003: Implement elementsFromPoint (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Cleanup, add a better test for tables Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/layout/LayoutTable.cpp ('k') | Source/core/layout/line/EllipsisBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1547 1547
1548 for (unsigned i = current.cells.size() ; i; ) { 1548 for (unsigned i = current.cells.size() ; i; ) {
1549 --i; 1549 --i;
1550 LayoutTableCell* cell = current.cells[i]; 1550 LayoutTableCell* cell = current.cells[i];
1551 LayoutPoint cellPoint = flipForWritingModeForChild(cell, adjuste dLocation); 1551 LayoutPoint cellPoint = flipForWritingModeForChild(cell, adjuste dLocation);
1552 if (static_cast<LayoutObject*>(cell)->nodeAtPoint(request, resul t, locationInContainer, cellPoint, action)) { 1552 if (static_cast<LayoutObject*>(cell)->nodeAtPoint(request, resul t, locationInContainer, cellPoint, action)) {
1553 updateHitTestResult(result, locationInContainer.point() - to LayoutSize(cellPoint)); 1553 updateHitTestResult(result, locationInContainer.point() - to LayoutSize(cellPoint));
1554 return true; 1554 return true;
1555 } 1555 }
1556 } 1556 }
1557 if (!result.isRectBasedTest()) 1557 if (!request.listBased())
1558 break; 1558 break;
1559 } 1559 }
1560 if (!result.isRectBasedTest()) 1560 if (!request.listBased())
1561 break; 1561 break;
1562 } 1562 }
1563 1563
1564 return false; 1564 return false;
1565 } 1565 }
1566 1566
1567 void LayoutTableSection::removeCachedCollapsedBorders(const LayoutTableCell* cel l) 1567 void LayoutTableSection::removeCachedCollapsedBorders(const LayoutTableCell* cel l)
1568 { 1568 {
1569 if (!table()->collapseBorders()) 1569 if (!table()->collapseBorders())
1570 return; 1570 return;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691). 1604 // FIXME: The table's direction should determine our row's direction, not th e section's (see bug 96691).
1605 if (!style()->isLeftToRightDirection()) 1605 if (!style()->isLeftToRightDirection())
1606 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing); 1606 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing);
1607 else 1607 else
1608 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing); 1608 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing);
1609 1609
1610 cell->setLogicalLocation(cellLocation); 1610 cell->setLogicalLocation(cellLocation);
1611 } 1611 }
1612 1612
1613 } // namespace blink 1613 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/layout/LayoutTable.cpp ('k') | Source/core/layout/line/EllipsisBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698