chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm - Issue 869793004: Bring up the Fast User Switcher on Shift+Click on the new Avatar Button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

Issue 869793004: Bring up the Fast User Switcher on Shift+Click on the new Avatar Button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change to right click and port to Mac UI Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_window.h ('k') | chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm » ('j') | chrome/browser/ui/views/frame/opaque_browser_frame_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

index 0482cbc6b975c0c84aea88c212c23b83a6dafbda..b1819a6dbb3f70d281758b22926ece18a14e7ebc 100644

--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

@@ -210,8 +210,15 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver,

}

- (IBAction)buttonClicked:(id)sender {

+ BrowserWindow::AvatarBubbleMode mode =

+ BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT;

Roger Tawa OOO till Jul 10th 2015/01/29 23:00:35 Two spaces.

anthonyvd 2015/01/30 15:02:20 Done.

+ if([NSEvent modifierFlags] & NSCommandKeyMask) {

+ mode = BrowserWindow::AVATAR_BUBBLE_MODE_FAST_USER_SWITCH;

+ }

Roger Tawa OOO till Jul 10th 2015/01/29 23:00:35 No need for { and }

anthonyvd 2015/01/30 15:02:20 Done.

[self showAvatarBubbleAnchoredAt:button_

- withMode:BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT

+ withMode:mode

withServiceType:signin::GAIA_SERVICE_TYPE_NONE];

}