Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 869793002: Move indexing into operations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/operation/operation.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index c1a8436ea45bd7b80eb8c108e193e48c49941d9a..c057af247d5d3106cac99d0665281a8d7adf225e 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -231,7 +231,7 @@ class PerformAnalysisOperation extends ServerOperation {
try {
CompilationUnit dartUnit = notice.compilationUnit;
if (dartUnit != null) {
- index.indexUnit(context, dartUnit);
+ server.addOperation(new _DartIndexOperation(context, dartUnit));
}
} catch (exception, stackTrace) {
server.sendServerErrorNotification(exception, stackTrace);
@@ -240,7 +240,7 @@ class PerformAnalysisOperation extends ServerOperation {
try {
HtmlUnit htmlUnit = notice.htmlUnit;
if (htmlUnit != null) {
- index.indexHtmlUnit(context, htmlUnit);
+ server.addOperation(new _HtmlIndexOperation(context, htmlUnit));
}
} catch (exception, stackTrace) {
server.sendServerErrorNotification(exception, stackTrace);
@@ -257,11 +257,32 @@ class _DartHighlightsOperation extends _DartNotificationOperation {
@override
void perform(AnalysisServer server) {
+ print('+server _DartHighlightsOperation');
sendAnalysisNotificationHighlights(server, file, unit);
}
}
+class _DartIndexOperation extends ServerOperation {
+ final AnalysisContext context;
+ final CompilationUnit unit;
+
+ _DartIndexOperation(this.context, this.unit);
+
+ @override
+ ServerOperationPriority get priority {
+ return ServerOperationPriority.ANALYSIS_INDEX;
+ }
+
+ @override
+ void perform(AnalysisServer server) {
+ print('+server _DartIndexOperation');
+ Index index = server.index;
+ index.indexUnit(context, unit);
+ }
+}
+
+
class _DartNavigationOperation extends _DartNotificationOperation {
_DartNavigationOperation(String file, CompilationUnit unit)
: super(file, unit);
@@ -321,6 +342,25 @@ class _DartOverridesOperation extends _DartNotificationOperation {
}
+class _HtmlIndexOperation extends ServerOperation {
+ final AnalysisContext context;
+ final HtmlUnit unit;
+
+ _HtmlIndexOperation(this.context, this.unit);
+
+ @override
+ ServerOperationPriority get priority {
+ return ServerOperationPriority.ANALYSIS_INDEX;
+ }
+
+ @override
+ void perform(AnalysisServer server) {
+ Index index = server.index;
+ index.indexHtmlUnit(context, unit);
+ }
+}
+
+
class _NotificationErrorsOperation extends ServerOperation {
final String file;
final LineInfo lineInfo;
« no previous file with comments | « pkg/analysis_server/lib/src/operation/operation.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698