Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 869783005: Files.app: Unobserve media scanner observer when foreground window is closed. (Closed)

Created:
5 years, 11 months ago by hirono
Modified:
5 years, 11 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Unobserve media scanner observer when foreground window is closed. BUG=420680 TEST=NONE Committed: https://crrev.com/a3523bc71b1cd7b159529caf806a5073faf78045 Cr-Commit-Position: refs/heads/master@{#312990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/import_controller.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thanks!
5 years, 11 months ago (2015-01-24 01:04:06 UTC) #2
Steve McKay
lgtm
5 years, 11 months ago (2015-01-24 01:11:02 UTC) #3
hirono
On 2015/01/24 01:11:02, Steve McKay wrote: > lgtm Thanks!
5 years, 11 months ago (2015-01-24 01:11:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869783005/1
5 years, 11 months ago (2015-01-24 01:12:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 01:50:25 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 01:51:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3523bc71b1cd7b159529caf806a5073faf78045
Cr-Commit-Position: refs/heads/master@{#312990}

Powered by Google App Engine
This is Rietveld 408576698