Issue 869783003: Cleanup SkPDFObject::emit*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 869783003: Cleanup SkPDFObject::emit* (Closed)

Created:
5 years, 11 months ago by hal.canary

Modified:
5 years, 11 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -66 lines)			Patch
M	src/pdf/SkPDFDocument.cpp	View	1 chunk	+7 lines, -3 lines	0 comments	Download
M	src/pdf/SkPDFTypes.h	View	3 chunks	+5 lines, -29 lines	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View	11 chunks	+17 lines, -26 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	4 chunks	+31 lines, -8 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869783003/1

5 years, 11 months ago (2015-01-23 19:37:37 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-23 19:45:13 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6a144345d742a53ffb15bbd83f2718022fca8df5