Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 869773005: Fix test-api/ObjectProtoToStringES6 (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix test-api/ObjectProtoToStringES6 Fixes tree closure caused by r26415 BUG=v8:3502 R=arv@chromium.org LOG=N Committed: https://crrev.com/600474ad442c2bc1740710b03fa4b5ab785e9f1b Cr-Commit-Position: refs/heads/master@{#26416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
caitp (gmail)
PTAL --- this works for me when running the failed commands listed in http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/1964/steps/Check/logs/ObjectProtoToStringES6 So ...
5 years, 10 months ago (2015-02-03 21:41:44 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 10 months ago (2015-02-03 21:50:21 UTC) #2
caitp (gmail)
On 2015/02/03 21:50:21, arv wrote: > LGTM I don't think I can land via the ...
5 years, 10 months ago (2015-02-03 21:50:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869773005/1
5 years, 10 months ago (2015-02-03 21:56:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 22:18:16 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 22:18:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/600474ad442c2bc1740710b03fa4b5ab785e9f1b
Cr-Commit-Position: refs/heads/master@{#26416}

Powered by Google App Engine
This is Rietveld 408576698