Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 869763003: Revert of [Storage] Consoliation of BlobItems with small size (Closed)

Created:
5 years, 11 months ago by kochi
Modified:
5 years, 11 months ago
Reviewers:
michaeln, piman, dmurph
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Storage] Consoliation of BlobItems with small size (patchset #8 id:140001 of https://codereview.chromium.org/821913004/) Reason for revert: This caused regression on some layout tests. e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28deps%29/builds/35407 fast/files/read-blob-async.html fast/files/workers/worker-read-blob-async.html fast/files/workers/worker-read-blob-sync.html fast/files/workers/worker-read-file-constructor-async.html http/tests/local/blob/send-data-blob.html http/tests/navigation/beacon-same-origin.html http/tests/websocket/bufferedAmount-after-send.html Original issue's description: > [Storage] Consolidation of BlobItems with small size > https://bit.ly/AutoBlobToDisk > > R=michaeln, piman > BUG=375297 > > Committed: https://crrev.com/4e45f41babddb10985c8c0afb9b0b6b9e8356094 > Cr-Commit-Position: refs/heads/master@{#312770} TBR=michaeln@chromium.org,piman@chromium.org,dmurph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=375297 Committed: https://crrev.com/0f82e12a3934b87edc51c800dfc9f27b9131da19 Cr-Commit-Position: refs/heads/master@{#312782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -105 lines) Patch
M content/child/webblobregistry_impl.h View 3 chunks +2 lines, -18 lines 0 comments Download
M content/child/webblobregistry_impl.cc View 5 chunks +40 lines, -67 lines 0 comments Download
M storage/common/data_element.h View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kochi
Created Revert of [Storage] Consoliation of BlobItems with small size
5 years, 11 months ago (2015-01-23 05:55:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869763003/1
5 years, 11 months ago (2015-01-23 05:56:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 05:57:40 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 05:58:43 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f82e12a3934b87edc51c800dfc9f27b9131da19
Cr-Commit-Position: refs/heads/master@{#312782}

Powered by Google App Engine
This is Rietveld 408576698