Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 869763002: SkTypeface to use SkStreamAsset. (Closed)

Created:
5 years, 11 months ago by bungeman-skia
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkTypeface to use SkStreamAsset. SkTypeface already requires typeface streams to support SkStreamAsset in practice, and in practice all users are already supplying them. Committed: https://skia.googlesource.com/skia/+/5f213d9627d2eefa7da81cd97f36754f75eb4ae9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -101 lines) Patch
M include/core/SkTypeface.h View 4 chunks +4 lines, -3 lines 0 comments Download
M include/ports/SkFontConfigInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/ports/SkFontMgr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M include/ports/SkFontMgr_indirect.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkFontDescriptor.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkFontMgr.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkTypeface.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/fonts/SkFontMgr_indirect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/fonts/SkGScalerContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkGScalerContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkFontConfigTypeface.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +11 lines, -31 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ports/SkFontMgr_android.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sfnt/SkOTUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/FontHostStreamTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
bungeman-skia
5 years, 11 months ago (2015-01-27 02:04:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869763002/1
5 years, 11 months ago (2015-01-27 02:05:18 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-27 02:05:19 UTC) #5
commit-bot: I haz the power
Presubmit check for 869763002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 11 months ago (2015-01-27 02:05:30 UTC) #7
reed1
lgtm
5 years, 11 months ago (2015-01-27 13:32:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869763002/1
5 years, 11 months ago (2015-01-27 13:32:55 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 13:39:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5f213d9627d2eefa7da81cd97f36754f75eb4ae9

Powered by Google App Engine
This is Rietveld 408576698