Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 869743005: add ui/display/util dependency where necessary under ui/ozone (Closed)

Created:
5 years, 11 months ago by oshima
Modified:
5 years, 11 months ago
Reviewers:
gunsch, spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add ui/display/util dependency where necessary under ui/ozone Note: ui/ozone/BUILD.gn file (for common ozone), and ui/ozone/platform/dri/dri.gypi already have dependency, and that's why it wasn't caught by bot. BUG=None TBR=spang@chromium.org, gunsch@chromium.org Committed: https://crrev.com/05f1f2c92362e73c6cad6aa46d26078b20e64f3e Cr-Commit-Position: refs/heads/master@{#312998}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/ozone/ozone.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
oshima
5 years, 11 months ago (2015-01-24 01:43:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869743005/20001
5 years, 11 months ago (2015-01-24 01:44:10 UTC) #3
spang
lgtm
5 years, 11 months ago (2015-01-24 01:45:12 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-24 02:35:05 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/05f1f2c92362e73c6cad6aa46d26078b20e64f3e Cr-Commit-Position: refs/heads/master@{#312998}
5 years, 11 months ago (2015-01-24 02:36:06 UTC) #6
gunsch
5 years, 11 months ago (2015-01-24 04:42:07 UTC) #7
Message was sent while issue was closed.
On 2015/01/24 02:36:06, I haz the power (commit-bot) wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/05f1f2c92362e73c6cad6aa46d26078b20e64f3e
> Cr-Commit-Position: refs/heads/master@{#312998}

Thanks for the quick fix!

Powered by Google App Engine
This is Rietveld 408576698