Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 869743004: Make extensions_utility target properly depend on extensions_strings (Closed)

Created:
5 years, 11 months ago by asargent_no_longer_on_chrome
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make extensions_utility target depend on extensions_strings This has been causing occasional build breakage on the bots, depending on whether we got unlucky in build ordering. Because extensions_common and extensions_browser both cause extensions_strings to run, I didn't notice this error before. BUG=451442 Committed: https://crrev.com/33f39fe7413561f88f312e4db3e1c2e5b9fa1b5a Cr-Commit-Position: refs/heads/master@{#312957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
asargent_no_longer_on_chrome
5 years, 11 months ago (2015-01-23 21:22:57 UTC) #2
Ken Rockot(use gerrit already)
too complicated not lgtm
5 years, 11 months ago (2015-01-23 21:23:54 UTC) #3
Ken Rockot(use gerrit already)
ok fine. lgtm
5 years, 11 months ago (2015-01-23 21:24:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869743004/1
5 years, 11 months ago (2015-01-23 21:35:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 22:56:30 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:58:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33f39fe7413561f88f312e4db3e1c2e5b9fa1b5a
Cr-Commit-Position: refs/heads/master@{#312957}

Powered by Google App Engine
This is Rietveld 408576698