Issue 869723002: ui/gfx: Cleanup - replace a call to SkBitmapToNSImage().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 869723002: ui/gfx: Cleanup - replace a call to SkBitmapToNSImage(). (Closed)

Created:
5 years, 11 months ago by tfarina

Modified:
5 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews, rsesek+watch_chromium.org, sky

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

ui/gfx: Cleanup - replace a call to SkBitmapToNSImage(). SkBitmapToNSImage() is deprecated and we should change its calls to SkBitmapToNSImageWithColorSpace(). BUG=69432 TEST=gfx_unittests R=thakis@chromium.org Committed: https://crrev.com/a95182ddbaa0e0e0a2504a0c4e0954f62cd9791c Cr-Commit-Position: refs/heads/master@{#313021}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/gfx/image/image_unittest_util.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 7 (1 generated)

Nico

lgtm In general, this isn't the type of change that the bug is about, but ...

5 years, 11 months ago (2015-01-24 04:31:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/869723002/1

5 years, 11 months ago (2015-01-24 14:51:45 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-24 15:38:02 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a95182ddbaa0e0e0a2504a0c4e0954f62cd9791c
Cr-Commit-Position: refs/heads/master@{#313021}